Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Prompt user to change directory in summary steps #3580

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Jul 10, 2023

Fixes #3476.

image

What this PR solves / how to test:

Tells the user to cd into the application they just created before suggesting other commands

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: e0d3e57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5513603446/npm-package-wrangler-3580

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3580/npm-package-wrangler-3580

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5513603446/npm-package-wrangler-3580 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5513603446/npm-package-cloudflare-pages-shared-3580

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #3580 (e0d3e57) into main (e16d027) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
+ Coverage   75.19%   75.23%   +0.03%     
==========================================
  Files         190      190              
  Lines       11160    11160              
  Branches     2944     2944              
==========================================
+ Hits         8392     8396       +4     
+ Misses       2768     2764       -4     

see 3 files with indirect coverage changes

Copy link
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this.

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Jul 11, 2023
@petebacondarwin petebacondarwin merged commit a7c1dd5 into main Jul 11, 2023
@petebacondarwin petebacondarwin deleted the c3-prompt-cd branch July 11, 2023 08:33
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
* C3: Prompt user to change directory in summary steps

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c3 doesn't tell people to change directory
3 participants