fix: register middleware once for module workers #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the middleware loader for module workers would register all middleware on each request. These registrations would be in addition to previous requests' registrations, meaning the middleware chain grew linearly with each request. This eventually lead to a stack overflow, as the middleware dispatcher is recursive. It also significantly slowed down requests over time. Editing code and reloading the dev server would reset the middleware chain. This change ensures middleware is only registered on the first request. Closes #2386
🦋 Changeset detectedLatest commit: 21bf848 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5520488221/npm-package-wrangler-3585You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3585/npm-package-wrangler-3585Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5520488221/npm-package-wrangler-3585 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5520488221/npm-package-cloudflare-pages-shared-3585Note that these links will no longer work once the GitHub Actions artifact expires. |
penalosa
approved these changes
Jul 11, 2023
Merged
lrapoport-cf
pushed a commit
that referenced
this pull request
Aug 11, 2023
Previously, the middleware loader for module workers would register all middleware on each request. These registrations would be in addition to previous requests' registrations, meaning the middleware chain grew linearly with each request. This eventually lead to a stack overflow, as the middleware dispatcher is recursive. It also significantly slowed down requests over time. Editing code and reloading the dev server would reset the middleware chain. This change ensures middleware is only registered on the first request. Closes #2386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2386
What this PR solves / how to test:
Previously, the middleware loader for module workers would register all middleware on each request. These registrations would be in addition to previous requests' registrations, meaning the middleware chain grew linearly with each request. This eventually lead to a stack overflow, as the middleware dispatcher is recursive. It also significantly slowed down requests over time. Editing code and reloading the dev server would reset the middleware chain.
This change ensures middleware is only registered on the first request.
To test this, follow the reproduction instructions here: https://github.com/BillBrower-Shopify/cf-workerd-crash-minimal
With this change stack overflows and slowdowns shouldn't be observed.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
TestsReviewer is to perform the following, as applicable: