Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] fix: include messages from API in errors #4593

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 12, 2023

Fixes #2775.

What this PR solves / how to test:

This PR ensures we display any messages returned from the API in our error messages. These might include additional information useful for debugging.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: change to how Wrangler reports errors

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner December 12, 2023 17:45
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 2adbd9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7387099008/npm-package-wrangler-4593

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7387099008/npm-package-wrangler-4593

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7387099008/npm-package-wrangler-4593 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7387099008/npm-package-miniflare-4593
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7387099008/npm-package-cloudflare-pages-shared-4593
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7387099008/npm-package-create-cloudflare-4593 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7506b24) 75.58% compared to head (2adbd9f) 75.27%.
Report is 35 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4593      +/-   ##
==========================================
- Coverage   75.58%   75.27%   -0.31%     
==========================================
  Files         242      242              
  Lines       12905    13023     +118     
  Branches     3318     3347      +29     
==========================================
+ Hits         9754     9803      +49     
- Misses       3151     3220      +69     
Files Coverage Δ
packages/wrangler/src/cfetch/index.ts 90.38% <100.00%> (+0.09%) ⬆️

... and 19 files with indirect coverage changes

@petebacondarwin petebacondarwin added the error-messaging Improving user facing error messages label Dec 22, 2023
@mrbbot mrbbot force-pushed the bcoll/include-messages-in-api-errors branch from df752fc to 2adbd9f Compare January 2, 2024 14:47
@mrbbot mrbbot merged commit c370026 into main Jan 2, 2024
17 checks passed
@mrbbot mrbbot deleted the bcoll/include-messages-in-api-errors branch January 2, 2024 15:09
@workers-devprod workers-devprod mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-messaging Improving user facing error messages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

display contents of FetchResult messages on error
3 participants