Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help message for listing scopes #4647

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix help message for listing scopes #4647

merged 1 commit into from
Dec 22, 2023

Conversation

irvinebroque
Copy link
Contributor

The actual command is --scopes-list but the error today says it is --list-scopes

The actual command is `--scopes-list` but the error today says it is `--list-scopes`
@irvinebroque irvinebroque requested a review from a team as a code owner December 20, 2023 20:44
Copy link

changeset-bot bot commented Dec 20, 2023

⚠️ No Changeset found

Latest commit: 2276681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7280587393/npm-package-wrangler-4647

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7280587393/npm-package-wrangler-4647

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7280587393/npm-package-wrangler-4647 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7280587393/npm-package-miniflare-4647
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7280587393/npm-package-cloudflare-pages-shared-4647
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7280587393/npm-package-create-cloudflare-4647 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4864013) 75.16% compared to head (2276681) 75.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4647      +/-   ##
==========================================
+ Coverage   75.16%   75.22%   +0.06%     
==========================================
  Files         242      242              
  Lines       13014    13014              
  Branches     3346     3346              
==========================================
+ Hits         9782     9790       +8     
+ Misses       3232     3224       -8     
Files Coverage Δ
packages/wrangler/src/index.ts 89.04% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@irvinebroque irvinebroque merged commit 0f424cf into main Dec 22, 2023
17 checks passed
@irvinebroque irvinebroque deleted the bib/list-scopes branch December 22, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants