Add support for named entrypoints #5215

GregBrimble · 2024-03-09T03:24:25Z

LDW exemption: CR-849919

What this PR solves / how to test

(updated by @mrbbot)

This PR adds support for named entrypoints to wrangler deploy and wrangler (pages) dev. This also enables support for JS RPC over multiple wrangler dev sessions.

Service bindings to other wrangler dev sessions are now implemented with workerd-native external service bindings instead of middleware. This is required to use Cap'n Proto over HTTP for JSRPC. This middleware was the last middleware that wrapped the env object. Code for wrapping env has been removed from the middleware loader. Implementing this for WorkerEntrypoints would've required us to look for named exports and apply env wrapping to all of these.

Author has addressed the following

Tests
- TODO (before merge)
- Included
- Not necessary because:
Changeset (Changeset guidelines)
- TODO (before merge)
- Included
- Not necessary because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
- Not necessary because:

changeset-bot · 2024-03-09T03:24:29Z

🦋 Changeset detected

Latest commit: d342bd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
wrangler	Minor
miniflare	Minor
@cloudflare/vitest-pool-workers	Patch
@cloudflare/pages-shared	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-03-09T03:27:17Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-wrangler-5215

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5215/npm-package-wrangler-5215

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-wrangler-5215 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-create-cloudflare-5215 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-cloudflare-kv-asset-handler-5215

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-miniflare-5215

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-cloudflare-pages-shared-5215

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8545615151/npm-package-cloudflare-vitest-pool-workers-5215

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20240329.1
`workerd`	1.20240329.0	1.20240329.0
`workerd --version`	1.20240329.0	2024-03-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

codecov · 2024-03-09T04:01:17Z

Codecov Report

Attention: Patch coverage is 69.29134% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 72.18%. Comparing base (b531b59) to head (d342bd6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5215      +/-   ##
==========================================
+ Coverage   72.12%   72.18%   +0.06%     
==========================================
  Files         331      331              
  Lines       17123    17175      +52     
  Branches     4371     4386      +15     
==========================================
+ Hits        12350    12398      +48     
- Misses       4773     4777       +4

Files	Coverage Δ
packages/wrangler/src/api/dev.ts	`83.33% <ø> (ø)`
...es/wrangler/src/api/integrations/platform/index.ts	`16.66% <ø> (ø)`
...wrangler/src/api/startDevWorker/ProxyController.ts	`61.97% <100.00%> (+1.40%)`	⬆️
packages/wrangler/src/api/startDevWorker/events.ts	`15.38% <ø> (ø)`
packages/wrangler/src/config/index.ts	`88.00% <100.00%> (ø)`
packages/wrangler/src/config/validation.ts	`89.89% <100.00%> (+0.03%)`	⬆️
packages/wrangler/src/deploy/deploy.ts	`93.31% <ø> (ø)`
...wrangler/src/deployment-bundle/apply-middleware.ts	`100.00% <ø> (ø)`
packages/wrangler/src/deployment-bundle/bundle.ts	`87.50% <ø> (-1.03%)`	⬇️
...src/deployment-bundle/create-worker-upload-form.ts	`90.32% <100.00%> (+0.12%)`	⬆️
... and 9 more

... and 5 files with indirect coverage changes

GregBrimble · 2024-03-26T17:00:27Z

packages/wrangler/templates/facade.d.ts

@@ -1,9 +1,24 @@
+// TODO(soon): remove once https://github.com/cloudflare/workerd/pull/1870 lands


Eagle has landed 🦅

Just need to publish to npm, and then we should be good to go. Looks like there was a problem with that latest run though: https://github.com/cloudflare/workerd/actions/runs/8438068332

Are we going to remove this file before merging?

Thanks for the reminder. Yes, I'll do that now.

packages/miniflare/src/index.ts

packages/miniflare/.prettierrc

packages/wrangler/src/cli.ts

packages/wrangler/src/dev-registry.ts

packages/wrangler/src/dev/miniflare.ts

Update error messages

GregBrimble · 2024-04-03T21:16:35Z

Okay, once these pass, I'm merging and will follow up with another PR to bump to the latest workerd version 🚀

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [wrangler](https://togithub.com/cloudflare/workers-sdk) ([source](https://togithub.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler)) | [`3.51.2` -> `3.52.0`](https://renovatebot.com/diffs/npm/wrangler/3.51.2/3.52.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/wrangler/3.52.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/wrangler/3.52.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/wrangler/3.51.2/3.52.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/wrangler/3.51.2/3.52.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>cloudflare/workers-sdk (wrangler)</summary> ### [`v3.52.0`](https://togithub.com/cloudflare/workers-sdk/blob/HEAD/packages/wrangler/CHANGELOG.md#3520) [Compare Source](https://togithub.com/cloudflare/workers-sdk/compare/[email protected]@3.52.0) ##### Minor Changes - [#5666](https://togithub.com/cloudflare/workers-sdk/pull/5666) [`81d9615`](https://togithub.com/cloudflare/workers-sdk/commit/81d961582da2db2b020305c63a9f1f1573ff873d) Thanks [@CarmenPopoviciu](https://togithub.com/CarmenPopoviciu)! - fix: Fix Pages config validation around Durable Objects Today Pages cannot deploy Durable Objects itself. For this reason it is mandatory that when declaring Durable Objects bindings in the config file, the `script_name` is specified. We are currently not failing validation if `script_name` is not specified but we should. These changes fix that. ##### Patch Changes - [#5610](https://togithub.com/cloudflare/workers-sdk/pull/5610) [`24840f6`](https://togithub.com/cloudflare/workers-sdk/commit/24840f67b6495a664f5463697aa49fa9478435b9) Thanks [@SuperchupuDev](https://togithub.com/SuperchupuDev)! - Mark `ts-json-schema-generator` as a dev dependency - [#5669](https://togithub.com/cloudflare/workers-sdk/pull/5669) [`a7e36d5`](https://togithub.com/cloudflare/workers-sdk/commit/a7e36d503f442a8225ffdedef30b569a8a396663) Thanks [@dario-piotrowicz](https://togithub.com/dario-piotrowicz)! - fix: fix broken Durable Object local proxying (when no `cf` property is present) A regression was introduced in wrangler 3.46.0 ([https://github.com/cloudflare/workers-sdk/pull/5215](https://togithub.com/cloudflare/workers-sdk/pull/5215)) which made it so that missing `Request#cf` properties are serialized as `"undefined"`, this in turn throws a syntax parse error when such values are parsed via `JSON.parse` breaking the communication with Durable Object local proxies. Fix such issue by serializing missing `Request#cf` properties as `"{}"` instead. - [#5616](https://togithub.com/cloudflare/workers-sdk/pull/5616) [`c6312b5`](https://togithub.com/cloudflare/workers-sdk/commit/c6312b5017279b31ce99c761e2063973f7d948bf) Thanks [@webbertakken](https://togithub.com/webbertakken)! - fix: broken link to durable object migrations docs - [#5482](https://togithub.com/cloudflare/workers-sdk/pull/5482) [`1b7739e`](https://togithub.com/cloudflare/workers-sdk/commit/1b7739e0af99860aa063f01c0a6e7712ac072fdb) Thanks [@DaniFoldi](https://togithub.com/DaniFoldi)! - docs: show new Discord url everywhere for consistency. The old URL still works, but https://discord.cloudflare.com is preferred. - Updated dependencies \[[`3a0d735`](https://togithub.com/cloudflare/workers-sdk/commit/3a0d7356bd8bc6fe614a3ef3f9c1278659555568), [`1b7739e`](https://togithub.com/cloudflare/workers-sdk/commit/1b7739e0af99860aa063f01c0a6e7712ac072fdb)]: - [email protected] - [@cloudflare/kv-asset-handler](https://togithub.com/cloudflare/kv-asset-handler)[@0](https://togithub.com/0).3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Johannes-Andersen/Johannes).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

GregBrimble force-pushed the entrypoints branch 2 times, most recently from 4961cfc to 6a5ec8e Compare March 9, 2024 03:52

GregBrimble force-pushed the entrypoints branch from 6a5ec8e to bf0e728 Compare March 20, 2024 20:10

GregBrimble changed the title ~~WIP entrypoints~~ Entrypoints Mar 22, 2024

GregBrimble marked this pull request as ready for review March 22, 2024 15:14

GregBrimble requested review from a team as code owners March 22, 2024 15:14

petebacondarwin marked this pull request as draft March 22, 2024 15:31

petebacondarwin marked this pull request as ready for review March 25, 2024 16:26

GregBrimble added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 25, 2024

mrbbot force-pushed the entrypoints branch from bf0e728 to d55b5d4 Compare March 25, 2024 23:54

mrbbot changed the title ~~Entrypoints~~ Add support for named entrypoints Mar 25, 2024

mrbbot force-pushed the entrypoints branch 3 times, most recently from 0084213 to 5350fe0 Compare March 26, 2024 13:37