Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump workerd to 1.20240329.0 #5455

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Mar 31, 2024

What this PR solves / how to test

This PR upgrades workerd to 1.20240329.0. This version contains some breaking changes to the experimental Fetcher#queue() method. It also introduces an accidental bump in the minimum supported TypeScript version to TypeScript 5.2 for @cloudflare/workers-types due to Symbol.dispose use. I did consider compatibility with older versions when making those types changes, but I missed a couple uses. 🙁

Author has addressed the following

@mrbbot mrbbot requested a review from a team as a code owner March 31, 2024 09:04
Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: c3f02d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 31, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-wrangler-5455

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5455/npm-package-wrangler-5455

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-wrangler-5455 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-create-cloudflare-5455 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-cloudflare-kv-asset-handler-5455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-miniflare-5455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-cloudflare-pages-shared-5455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8497270948/npm-package-cloudflare-vitest-pool-workers-5455

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.1
workerd 1.20240329.0 1.20240329.0
workerd --version 1.20240329.0 2024-03-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mrbbot mrbbot force-pushed the bcoll/workerd-2024-03-29-bump branch from 310187d to c3f02d6 Compare March 31, 2024 09:34
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (63216f1) to head (c3f02d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5455      +/-   ##
==========================================
+ Coverage   72.15%   72.24%   +0.09%     
==========================================
  Files         326      326              
  Lines       16848    16848              
  Branches     4311     4311              
==========================================
+ Hits        12156    12172      +16     
+ Misses       4692     4676      -16     

see 8 files with indirect coverage changes

@mrbbot mrbbot merged commit d994066 into main Mar 31, 2024
18 checks passed
@mrbbot mrbbot deleted the bcoll/workerd-2024-03-29-bump branch March 31, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants