Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Add Smart Placement examle to wrangler.toml templates #5684

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Apr 22, 2024

What this PR solves / how to test

Adds a commented out example of how to configure Smart Placement in the wrangler.toml of C3 templates.

Author has addressed the following

@jculvey jculvey requested a review from a team as a code owner April 22, 2024 19:46
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: ab6eba9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-wrangler-5684

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5684/npm-package-wrangler-5684

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-wrangler-5684 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-create-cloudflare-5684 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-cloudflare-kv-asset-handler-5684
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-miniflare-5684
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-cloudflare-pages-shared-5684
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8789966700/npm-package-cloudflare-vitest-pool-workers-5684

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jculvey jculvey merged commit c81fa65 into main Apr 23, 2024
23 checks passed
@jculvey jculvey deleted the c3-smart-placement-docs branch April 23, 2024 16:52
@IgorMinar
Copy link
Contributor

Nice! thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants