Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a clearer user error when trying to use a python worker without the python_workers compatibility flag specified #6572

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test

Fixes #5479

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: not covered by e2e tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: messsaging improvement

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: f95bf2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-wrangler-6572

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6572/npm-package-wrangler-6572

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-wrangler-6572 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-create-cloudflare-6572 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-cloudflare-kv-asset-handler-6572
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-miniflare-6572
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-cloudflare-pages-shared-6572
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-cloudflare-vitest-pool-workers-6572
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-cloudflare-workers-editor-shared-6572
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10582828927/npm-package-cloudflare-workers-shared-6572

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, but otherwise LGTM!

packages/wrangler/src/config/index.ts Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
@penalosa penalosa merged commit 0d83428 into main Aug 27, 2024
21 checks passed
@penalosa penalosa deleted the 5479-bug-need-a-better-error-for-dev-ing-python-modules-when-missing-the-python_workers-compatibility-flag branch August 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Need a better error for dev-ing Python modules when missing the python_workers compatibility flag
2 participants