Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): Validate additional config properties for [observability] #6812

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Sep 24, 2024

What this PR solves / how to test

Fixes N/A but please refer to #2586 for the wider scope feat request

wrangler dev
Screenshot 2024-09-24 at 08 49 43

wrangler dev --env staging
Screenshot 2024-09-24 at 08 47 59

wrangler dev --env production
Screenshot 2024-09-24 at 08 48 35

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: captured by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner September 24, 2024 07:11
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: a461332

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-wrangler-6812

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6812/npm-package-wrangler-6812

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-wrangler-6812 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-create-cloudflare-6812 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-cloudflare-kv-asset-handler-6812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-miniflare-6812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-cloudflare-pages-shared-6812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-cloudflare-vitest-pool-workers-6812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-cloudflare-workers-editor-shared-6812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11008814146/npm-package-cloudflare-workers-shared-6812

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.5
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit f700d37 into main Sep 24, 2024
25 of 29 checks passed
@edmundhung edmundhung deleted the carmen/validate-add-props branch September 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants