Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-cloudflare): enable observability for Workers templates #6817

Closed
wants to merge 2 commits into from

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Sep 24, 2024

What this PR solves / how to test

Adds Workers Observability to newly generated create-cloudflare projects.

Fixes WO-198

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Only adds an already tested setting to template configs
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Only adds an already tested setting to template configs
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation

@zebp zebp requested review from a team as code owners September 24, 2024 16:58
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 2a8fbd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -3,3 +3,9 @@ name = "<TBD>"
compatibility_date = "<TBD>"
main = "./dist/server/server.mjs"
assets = { directory = "./dist/browser", binding = "ASSETS" }

# Workers Logs
# Docs: https://rohin-observability-docs.cloudflare-docs-7ou.pages.dev/workers/observability/logs/workers-logs/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all temporary links that I'll update when the docs PR gets merged before this PR is merged

@zebp
Copy link
Contributor Author

zebp commented Sep 24, 2024

I also added the settings to the experimental configs, but I'm not sure if we should actually do that. cc @rohinlohe

Copy link
Contributor

github-actions bot commented Sep 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-wrangler-6817

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6817/npm-package-wrangler-6817

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-wrangler-6817 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-create-cloudflare-6817 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-cloudflare-kv-asset-handler-6817
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-miniflare-6817
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-cloudflare-pages-shared-6817
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-cloudflare-vitest-pool-workers-6817
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-cloudflare-workers-editor-shared-6817
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11020317831/npm-package-cloudflare-workers-shared-6817

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.5
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@zebp
Copy link
Contributor Author

zebp commented Sep 24, 2024

Closing in favor of #6820 which doesn't use a fork.

@zebp zebp closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant