Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates #6826

Merged
merged 4 commits into from
Sep 25, 2024
Merged

chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates #6826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
006080e
chore(deps): bump the workerd-and-workers-types group across 1 direct…
dependabot[bot] Sep 25, 2024
982e446
chore: update dependencies of "miniflare" package
Sep 25, 2024
55b4e4a
Use symbol to identify internal classes
penalosa Sep 25, 2024
4c65020
remove intermediate variable
penalosa Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/dependabot-update-6826.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"miniflare": patch
---

chore: update dependencies of "miniflare" package

The following dependency versions have been updated:

| Dependency | From | To |
| ------------------------- | ------------- | ------------- |
| workerd | 1.20240909.0 | 1.20240925.0 |
| @cloudflare/workers-types | ^4.20240909.0 | ^4.20240925.0 |
2 changes: 1 addition & 1 deletion fixtures/additional-modules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/asset-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"devDependencies": {
"@cloudflare/vitest-pool-workers": "workspace:*",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240821.1",
"@cloudflare/workers-types": "^4.20240925.0",
"run-script-os": "^1.1.6",
"undici": "^5.28.4",
"vitest": "catalog:default",
Expand Down
2 changes: 1 addition & 1 deletion fixtures/external-durable-objects-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/external-service-bindings-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"concurrently": "^8.2.2",
"undici": "^5.28.4",
"wrangler": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion fixtures/get-platform-proxy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/local-mode-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/node": "20.8.3",
"buffer": "^6.0.3",
"wrangler": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion fixtures/node-app-pages/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/nodejs-als-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
}
Expand Down
2 changes: 1 addition & 1 deletion fixtures/nodejs-hybrid-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/pg": "^8.11.2",
"pg": "8.11.3",
"pg-cloudflare": "^1.1.1",
Expand Down
2 changes: 1 addition & 1 deletion fixtures/pages-dev-proxy-with-script/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/pages-functions-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"pages-plugin-example": "workspace:*",
"undici": "^5.28.4",
"wrangler": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion fixtures/pages-functions-with-routes-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/pages-plugin-mounted-on-root-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"pages-plugin-example": "workspace:*",
"undici": "^5.28.4",
"wrangler": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion fixtures/pages-simple-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/vitest-pool-workers-examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@cloudflare/vitest-pool-workers": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/node": "20.8.3",
"ext-dep": "file:./internal-module-resolution/vendor/ext-dep",
"jose": "^5.2.2",
Expand Down
2 changes: 1 addition & 1 deletion fixtures/worker-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"start": "wrangler dev --x-dev-env"
},
"devDependencies": {
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"wrangler": "workspace:*"
},
"volta": {
Expand Down
2 changes: 1 addition & 1 deletion fixtures/workers-with-assets-only/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion fixtures/workers-with-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"undici": "^5.28.4",
"wrangler": "workspace:*"
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"@changesets/parse": "^0.4.0",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@ianvs/prettier-plugin-sort-imports": "4.2.1",
"@manypkg/cli": "^0.21.4",
"@turbo/gen": "^1.10.13",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@cloudflare/cli": "workspace:*",
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@iarna/toml": "^3.0.0",
"@types/command-exists": "^1.2.0",
"@types/cross-spawn": "^6.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/edge-preview-authenticated-proxy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/cookie": "^0.6.0",
"cookie": "^0.6.0",
"promjs": "^0.4.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/format-errors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"mustache": "^4.2.0",
"promjs": "^0.4.2",
"toucan-js": "^3.3.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/kv-asset-handler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
},
"devDependencies": {
"@ava/typescript": "^4.1.0",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/mime": "^3.0.4",
"@types/node": "20.8.3",
"@types/service-worker-mock": "^2.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/miniflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"glob-to-regexp": "^0.4.1",
"stoppable": "^1.1.0",
"undici": "^5.28.4",
"workerd": "1.20240909.0",
"workerd": "1.20240925.0",
"ws": "^8.17.1",
"youch": "^3.2.2",
"zod": "^3.22.3"
Expand All @@ -59,7 +59,7 @@
"@ava/typescript": "^4.1.0",
"@cloudflare/kv-asset-handler": "workspace:*",
"@cloudflare/workers-shared": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@microsoft/api-extractor": "^7.47.0",
"@types/debug": "^4.1.7",
"@types/estree": "^1.0.0",
Expand Down
15 changes: 12 additions & 3 deletions packages/miniflare/src/workers/core/proxy.worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,20 @@ function objectContainsFunctions(
return false;
}

function isObject(value: unknown) {
return value && typeof value === "object";
function isObject(
value: unknown
): value is Record<string | number | symbol, unknown> {
return !!value && typeof value === "object";
}

function getType(value: unknown) {
return Object.prototype.toString.call(value).slice(8, -1); // `[object <type>]`
}

function isInternal(value: unknown) {
return isObject(value) && value[Symbol.for("cloudflare:internal-class")];
}

type Env = Record<string, unknown> & {
[CoreBindings.DATA_PROXY_SECRET]: ArrayBuffer;
};
Expand All @@ -119,7 +125,10 @@ export class ProxyServer implements DurableObject {
// should only ever return `Object`, as none override `Symbol.toStringTag`
// https://tc39.es/ecma262/multipage/fundamental-objects.html#sec-object.prototype.tostring
const type = getType(value);
if ((type === "Object" && !isPlainObject(value)) || type === "Promise") {
if (
((type === "Object" || isInternal(value)) && !isPlainObject(value)) ||
type === "Promise"
) {
const address = this.nextHeapAddress++;
this.heap.set(address, value);
assert(value !== null);
Expand Down
2 changes: 1 addition & 1 deletion packages/pages-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@miniflare/cache": "^2.14.2",
"@miniflare/core": "^2.14.2",
"@miniflare/html-rewriter": "^2.14.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/playground-preview-worker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/cookie": "^0.6.0",
"cookie": "^0.6.0",
"itty-router": "^4.0.13",
Expand Down
2 changes: 1 addition & 1 deletion packages/prerelease-registry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"wrangler": "workspace:*"
},
"volta": {
Expand Down
2 changes: 1 addition & 1 deletion packages/quick-edit-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
],
"devDependencies": {
"@cloudflare/workers-tsconfig": "workspace:^",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"esbuild": "0.17.19",
"esbuild-register": "^3.5.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/vitest-pool-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/node": "20.8.3",
"@types/semver": "^7.5.1",
"@vitest/runner": "catalog:default",
Expand Down
2 changes: 1 addition & 1 deletion packages/workers-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"devDependencies": {
"@cloudflare/eslint-config-worker": "workspace:*",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/mime": "^3.0.4",
"concurrently": "^8.2.2",
"esbuild": "0.17.19",
Expand Down
2 changes: 1 addition & 1 deletion packages/workers.new/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@cloudflare/vitest-pool-workers": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@types/node": "20.8.3",
"miniflare": "workspace:*",
"typescript": "^5.5.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/wrangler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"selfsigned": "^2.0.1",
"source-map": "^0.6.1",
"unenv": "npm:[email protected]",
"workerd": "1.20240909.0",
"workerd": "1.20240925.0",
"xxhash-wasm": "^1.0.1"
},
"devDependencies": {
Expand All @@ -93,7 +93,7 @@
"@cloudflare/pages-shared": "workspace:^",
"@cloudflare/types": "^6.18.4",
"@cloudflare/workers-tsconfig": "workspace:*",
"@cloudflare/workers-types": "^4.20240909.0",
"@cloudflare/workers-types": "^4.20240925.0",
"@cspotcode/source-map-support": "0.8.1",
"@iarna/toml": "^3.0.0",
"@microsoft/api-extractor": "^7.47.0",
Expand Down Expand Up @@ -176,7 +176,7 @@
"yoga-layout": "file:../../vendor/yoga-layout-2.0.0-beta.1.tgz"
},
"peerDependencies": {
"@cloudflare/workers-types": "^4.20240909.0"
"@cloudflare/workers-types": "^4.20240925.0"
},
"peerDependenciesMeta": {
"@cloudflare/workers-types": {
Expand Down
Loading
Loading