Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip angular c3 e2e test on bun #6845

Merged
merged 1 commit into from
Sep 27, 2024
Merged

skip angular c3 e2e test on bun #6845

merged 1 commit into from
Sep 27, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Sep 27, 2024

What this PR solves / how to test

Fixes #0000

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: disabling flakey test
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: c3 e2e tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: test change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test change

@RamIdeas RamIdeas requested review from a team as code owners September 27, 2024 09:21
Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: b81e058

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-wrangler-6845

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6845/npm-package-wrangler-6845

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-wrangler-6845 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-create-cloudflare-6845 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-cloudflare-kv-asset-handler-6845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-miniflare-6845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-cloudflare-pages-shared-6845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-cloudflare-vitest-pool-workers-6845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-cloudflare-workers-editor-shared-6845
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11068028350/npm-package-cloudflare-workers-shared-6845

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas added skip-pr-description-validation Skip validation of the required PR description format and removed skip-pr-description-validation Skip validation of the required PR description format labels Sep 27, 2024
@petebacondarwin petebacondarwin merged commit c5c290d into main Sep 27, 2024
42 of 43 checks passed
@petebacondarwin petebacondarwin deleted the c3-skip-bun-angular branch September 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants