Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-cloudflare): allows user going back to the project name prompt #6846

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Sep 27, 2024

What this PR solves / how to test

Fixes N/A

This PR adds the ability to go back to the project name prompt, mainly to give users an idea that they can always come back to the previous question when answering the prompt early on.

Screenshot 2024-10-01 at 12 51 22

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no other impact
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ux improvement only

@edmundhung edmundhung requested review from a team as code owners September 27, 2024 13:09
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: 5dc1192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung
Copy link
Member Author

I am not sure if this should be consider a feat of fix 🤔

Copy link
Contributor

github-actions bot commented Sep 27, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-wrangler-6846

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6846/npm-package-wrangler-6846

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-wrangler-6846 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-create-cloudflare-6846 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-cloudflare-kv-asset-handler-6846
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-miniflare-6846
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-cloudflare-pages-shared-6846
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-cloudflare-vitest-pool-workers-6846
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-cloudflare-workers-editor-shared-6846
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11385494099/npm-package-cloudflare-workers-shared-6846

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/c3-go-back-to-project-name branch from 2a8c1cd to 9895d60 Compare October 1, 2024 11:47
@edmundhung edmundhung force-pushed the edmundhung/c3-go-back-to-project-name branch from 9895d60 to f788fb5 Compare October 17, 2024 10:23
@CarmenPopoviciu CarmenPopoviciu merged commit ae4bfea into main Oct 17, 2024
30 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the edmundhung/c3-go-back-to-project-name branch October 17, 2024 13:38
@nevikashah
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants