Fix combo of --x-dev-env and --x-registry

[RamIdeas]

What this PR solves / how to test

Fixes N/A

This PR fixes a race condition causing the dev registry registrations of a quickly-reloaded worker to occur out-of-order. Sometimes overwriting the valid registration with the outdated registration details.

Also reenable –x-registry flag in fixtures

Author has addressed the following

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because: fixing fixture tests flakiness
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Changeset included
  • Changeset not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: implementation detail

[changeset-bot]

⚠️ No Changeset found

Latest commit: 79b4c43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[RamIdeas]

This is the fix

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-wrangler-6871

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6871/npm-package-wrangler-6871

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-wrangler-6871 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-create-cloudflare-6871 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-cloudflare-kv-asset-handler-6871

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-miniflare-6871

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-cloudflare-pages-shared-6871

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-cloudflare-vitest-pool-workers-6871

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-cloudflare-workers-editor-shared-6871

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11126646697/npm-package-cloudflare-workers-shared-6871

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240925.0
workerd	1.20240925.0	1.20240925.0
workerd --version	1.20240925.0	2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[andyjessop]

This was confusing me for a moment as prop initialisers are normally at the top of the class definition. Is there a reason to have it down here?

[RamIdeas]

Just colocating its definition with the method that modifies it

[RamIdeas]

Closing. Adding –x-registry flag to fixtures in #6893