Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow assets in multiworker setup #7290

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Nov 19, 2024

#7251 will allow running multiple workers in one Miniflare instance. Currently we only set up the router/asset worker for the first worker passed to miniflare, assuming this will be the only user worker. This PR will make sure assets works regardless of how many 'user workers' are passed in and at what point.


  • Tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: I don't think there are any existing docs covering this.

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: ab5187d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added the e2e Run e2e tests on a PR label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-wrangler-7290

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7290/npm-package-wrangler-7290

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-wrangler-7290 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-create-cloudflare-7290 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-kv-asset-handler-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-miniflare-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-pages-shared-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-vitest-pool-workers-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-workers-editor-shared-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-workers-shared-7290
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914339511/npm-package-cloudflare-workflows-shared-7290

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen changed the title feat: allow assets in multiworker setup fix: allow assets in multiworker setup Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant