Skip to content

Commit

Permalink
Don't set packageManager default via action.yml
Browse files Browse the repository at this point in the history
We need to distinguish between when the value is and isn't set in order to perform inference based on lockfile and only fallback to the default of npm if inference fails.
  • Loading branch information
1000hz committed Oct 10, 2023
1 parent 0e6f0d3 commit 1814662
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/dirty-poets-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler-action": patch
---

Fixed the package manager not being inferred based on lockfile when the `packageManager` input isn't set.
3 changes: 1 addition & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,5 @@ inputs:
description: "A string of environment variable names, separated by newlines. These will be bound to your Worker using the values of matching environment variables declared in `env` of this workflow."
required: false
packageManager:
description: "The package manager you'd like to use to install and run wrangler. If not specified, a value will be inferred based on the presence of a lockfile. Valid values: [npm, pnpm, yarn, bun]"
description: "The package manager you'd like to use to install and run wrangler. If not specified, the preferred package manager will be inferred based on the presence of a lockfile or fallback to using npm if no lockfile is found. Valid values are `npm` | `pnpm` | `yarn` | `bun`."
required: false
default: npm
2 changes: 1 addition & 1 deletion test/bun/package.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"name": "wrangler-action-bun-test",
"name": "wrangler-action-bun-test"
}

0 comments on commit 1814662

Please sign in to comment.