Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about packageManager config #242

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Mar 10, 2024

just something I bumped into today

image

@capaj capaj requested a review from a team as a code owner March 10, 2024 15:23
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we should be able to infer the package manager in use??

@petebacondarwin petebacondarwin merged commit c214b69 into cloudflare:main Mar 11, 2024
1 check passed
@Cherry
Copy link
Contributor

Cherry commented Mar 25, 2024

@petebacondarwin This is inferred by #190 and then fixed in #193, and I'm not really sure the "default" copy/pasted config should use pnpm - that's definitely not the standard.

"The package manager you'd like to use to install and run wrangler. If not specified, the preferred package manager will be inferred based on the presence of a lockfile or fallback to using npm if no lockfile is found. Valid values are npm | pnpm | yarn | bun."

You do not need to specify packageManager as the docs now suggests, as long as you're running an up to date version.

@Cherry
Copy link
Contributor

Cherry commented Mar 25, 2024

The detection of pnpm looks for a pnpm-lock.yaml file in the working directory, but only after looking for a package-lock.json, and then a yarn.lock.

If you have a pnpm-lock.yaml committed, and none of these other files, it should work as expected.

@@ -52,6 +53,10 @@ jobs:

## Configuration

### packageManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this header makes all the following paragraphs appear as if they were part of the packageManager docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants