This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
While working on tests for `get_deployments()`, I found that any changed to `src/settings/toml/tests/mod.rs` would cause the whole Wrangler library to be rebuilt, not just the tests. I found it was because Cargo reran the build.rs on every change to every file, which was far slower than necessary. I could have changed the build script to output `rerun-if-changed`, but it turns out it wasn't even necessary in the first place; so this improves the first-time build time as well. - Use `CARGO_MANIFEST_DIR` instead of the working directory of the build script These are always the same. This also allows using the env variable directly instead of removing the quotes after the fact - Use `--cfg debug_assertions` instead of the `PROFILE` cargo sets for build scripts In theory these could be different, but in practice we never build release artifacts with debug assertions, so this shouldn't affect the behavior unless someone explicitly builds from source and also modifies `Cargo.toml` to enable assertions.
- Loading branch information
Showing
5 changed files
with
5 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters