fix #255: stop cleaning webpack build artifacts

src/commands/build/wranglerjs/bundle.rs

@@ -6,8 +6,6 @@ use std::fs::File;
 use std::io::prelude::*;
 use std::path::{Path, PathBuf};
 
-use log::info;
-
 use crate::commands::build::wranglerjs::output::WranglerjsOutput;
 use crate::settings::binding::Binding;
 use crate::settings::metadata;
@@ -57,12 +55,6 @@ impl Bundle {
         let mut metadata_file = File::create(self.metadata_path())?;
         metadata_file.write_all(metadata.as_bytes())?;
 
-        // cleanup {Webpack} dist, if specified.
-        if let Some(dist_to_clean) = &wranglerjs_output.dist_to_clean {
-            info!("Remove {}", dist_to_clean);
-            fs::remove_dir_all(dist_to_clean).expect("could not clean Webpack dist.");
-        }
-
         Ok(())
     }
 
@@ -150,7 +142,7 @@ mod tests {
         let wranglerjs_output = WranglerjsOutput {
             errors: vec![],
             script: "".to_string(),
-            dist_to_clean: None,
+
             wasm: None,
         };
         let bundle = Bundle::new_at(out.clone());
@@ -171,7 +163,6 @@ mod tests {
         let wranglerjs_output = WranglerjsOutput {
             errors: vec![],
             script: "foo".to_string(),
-            dist_to_clean: None,
             wasm: None,
         };
         let bundle = Bundle::new_at(out.clone());
@@ -190,7 +181,6 @@ mod tests {
             errors: vec![],
             script: "".to_string(),
             wasm: Some("abc".to_string()),
-            dist_to_clean: None,
         };
         let bundle = Bundle::new_at(out.clone());
 
@@ -208,7 +198,6 @@ mod tests {
             errors: vec![],
             script: "".to_string(),
             wasm: Some("abc".to_string()),
-            dist_to_clean: None,
         };
         let bundle = Bundle::new_at(out.clone());
 
@@ -231,7 +220,6 @@ mod tests {
             errors: vec!["a".to_string(), "b".to_string()],
             script: "".to_string(),
             wasm: None,
-            dist_to_clean: None,
         };
         assert!(wranglerjs_output.has_errors());
         assert!(wranglerjs_output.get_errors() == "a\nb");

src/commands/build/wranglerjs/mod.rs

@@ -41,7 +41,7 @@ pub fn run_build(project: &Project) -> Result<(), failure::Error> {
             serde_json::from_str(&output).expect("could not parse wranglerjs output");
 
         if wranglerjs_output.has_errors() {
-            message::user_error(&format!("{}", wranglerjs_output.get_errors()));
+            message::user_error(wranglerjs_output.get_errors().as_str());
             failure::bail!("Webpack returned an error");
         }
 

src/commands/build/wranglerjs/output.rs

@@ -11,10 +11,6 @@ use std::io::prelude::*;
 pub struct WranglerjsOutput {
     pub wasm: Option<String>,
     pub script: String,
-    // {wranglerjs} will send us the path to the {dist} directory that {Webpack}
-    // used; it's tedious to remove a directory with content in JavaScript so
-    // let's do it in Rust!
-    pub dist_to_clean: Option<String>,
     // Errors emited by {wranglerjs}, if any
     pub errors: Vec<String>,
 }
@@ -58,7 +54,6 @@ mod tests {
         let wranglerjs_output = WranglerjsOutput {
             errors: vec![],
             script: "aaaa".to_string(),
-            dist_to_clean: None,
             wasm: None,
         };
 
@@ -70,7 +65,6 @@ mod tests {
         let wranglerjs_output = WranglerjsOutput {
             errors: vec![],
             script: "".to_string(),
-            dist_to_clean: None,
             wasm: Some("abc".to_string()),
         };
 

wranglerjs/index.js

@@ -75,7 +75,6 @@ compiler.run((err, stats) => {
   const bundle = {
     wasm: null,
     script: "",
-    dist_to_clean: fullConfig.output.path,
     errors: jsonStats.errors
   };