Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Add bucket config to wrangler.toml #447

Closed
ashleymichal opened this issue Aug 16, 2019 · 4 comments
Closed

Add bucket config to wrangler.toml #447

ashleymichal opened this issue Aug 16, 2019 · 4 comments
Assignees
Labels
blocked feature Feature requests and suggestions regression Something is broken, but works in previous releases
Milestone

Comments

@ashleymichal
Copy link
Contributor

ashleymichal commented Aug 16, 2019

adding bucket to a kv namespace entry to allow Wrangler to orchestrate sync of a directory full of assets. Bucket should be a relative path from the location of the wrangler.toml to a directory including assets to be uploaded to KV.

EDITED: s/project.assets/kv-namespace.bucket/

@ashleymichal ashleymichal added feature Feature requests and suggestions subject - kv regression Something is broken, but works in previous releases design labels Aug 16, 2019
@ashleymichal ashleymichal added this to the KV Additions milestone Aug 16, 2019
@ashleymichal ashleymichal self-assigned this Aug 16, 2019
@1000hz
Copy link

1000hz commented Aug 26, 2019

Should there be a default set of directories that get used if no project.assets is specified? We could include some commonly used static-file directories, i.e. public dist build, so any files in these directories would automatically get uploaded if present. This would get us closer to zero-config deployment for many frameworks.

@ashleymichal
Copy link
Contributor Author

Should there be a default set of directories that get used if no project.assets is specified?

@1000hz i feel like this would be very presumptuous in the context of the current design given that static sites are not the primary use case; however if we instead added a flag to wrangler publish to indicate that the users' intent is to deploy a static site, this would be a good feature.

@ashleymichal
Copy link
Contributor Author

current status of this feature is a little up in the air; the design at the moment is to nest "bucket" under a kv-namespaces entry. it is possible that this design will change in the next week.

@ashleymichal ashleymichal changed the title Add assets config to wrangler.toml Add bucket config to wrangler.toml Aug 30, 2019
@ashleymichal
Copy link
Contributor Author

this baseline feature is complete as of #473 . opening new issue for static config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked feature Feature requests and suggestions regression Something is broken, but works in previous releases
Projects
None yet
Development

No branches or pull requests

2 participants