This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Alewis/refactor key list #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
force-pushed
the
alewis/refactor-key-list
branch
from
6fbf69a
to
fd1bb02
Compare
ashleymichal
changed the base branch from
alewis/refactor-publish-sites
to
feat-kv-additions
ashleymichal
added
refactor
regression
|
need to handle errors |
ashleymichal
force-pushed
the
alewis/refactor-key-list
branch
3 times, most recently
from
15c8388
to
0938425
Compare
|
I opened a PR (#536) that should make this logic a little simpler--let me know what you think! |
Perfect! Merged. Ready for review |
gabbifish
approved these changes
Sep 9, 2019
gabbifish
changed the base branch from
feat-kv-additions
to
feat-kv-commands
ashleymichal
changed the title
ashleymichal
changed the base branch from
feat-kv-commands
to
feat-kv-additions
…r re-fetching pages of KV data
ashleymichal
force-pushed
the
alewis/refactor-key-list
branch
from
b382249
to
80f8a4a
Compare
ashleymichal
changed the base branch from
feat-kv-additions
to
feat-kv-commands
ashleymichal
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #447
This extracts the logic of fetching all of the keys for a given KV namespace into an iterator, which will allow us to either print to standard out, or collect the keys as needed for other operations, without repeating all the fetch cursor logic. This is handy for implementing
sync, which will need to collect a list of uploaded keys from the API to compare to local keys in order to decide what to delete.