-
Notifications
You must be signed in to change notification settings - Fork 337
Workers Sites uploads do not include files that are in .gitignore #958
Comments
Hey @lighterpl - my guess is that these assets are actually being uploaded and they're just linked incorrectly from within the application. That being said this is just a hunch, and it's very possible that they are not being uploaded! The best way for us to help here is if you could point us to a repository that reproduces the problem and then we can investigate :) |
Seems that it happens when there is a subfolder anywhere inside the ./public directory named “dist” all files inside are ignored. |
Aha! It seems that Wrangler is not uploading files in the |
…tory traversal (#981) * Fix #958: Do not factor in .gitignore into workers sites upload directory traversal * make sure to delete interior public/ directory in test directory before deleting test directory; this looks like a weird windows quirk with fs::remove_dir_all * try writeln? * drop/close gitignore file before deleting directory * comment on why our test calls drop() * Update src/commands/kv/bucket/mod.rs
🐛 Bug Report
Environment
Steps to reproduce
Generate workers site project, set account id, api access granted using workers site template permissions.
Static file export of Wordpress site, placed in ./public folder
Run wrangler publish
Some css and js and font files are not uploaded (as seen by http 500 error in chrome dev tools for those resources)
I suspect this is because the files are in a deep folder structure, because when these files are moved to root public folder or 1 folder deep, wrangler does not skip them and they are successfully deployed.
What did you expect to see?
I expect ALL files in ./public folder to be deployed
What did you see instead?
Some files are skipped during wrangler publish process
The text was updated successfully, but these errors were encountered: