This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Sends custom user agent with cloudflare-rs #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/uniform-user-agent
branch
from
3be4e7f
to
b6a404e
Compare
ashleymichal
suggested changes
Feb 14, 2020
EverlastingBugstopper
force-pushed
the
avery/uniform-user-agent
branch
from
b6a404e
to
99fb9ca
Compare
EverlastingBugstopper
requested review from
ashleymichal and
ashleygwilliams
ashleymichal
previously requested changes
Feb 18, 2020
ashleymichal
dismissed
their stale review
don't want to block as i am going out of town
src/http/cf.rs
Outdated
| ) | ||
| } | ||
|
|
||
| pub fn kv_auth_client(user: &GlobalUser) -> Result<HttpApiClient, failure::Error> { |
There was a problem hiding this comment.
maybe we rename to long_timeout_auth_client?
There was a problem hiding this comment.
yeah prolly. or we handle config less centrally in another iteration of this refactor
ashleymichal
approved these changes
Apr 7, 2020
src/commands/config/mod.rs
Outdated
| @@ -46,7 +45,7 @@ pub fn global_config(user: &GlobalUser, verify: bool) -> Result<(), failure::Err | |||
| // validate_credentials() checks the /user/tokens/verify endpoint (for API token) | |||
| // or /user endpoint (for global API key) to ensure provided credentials actually work. | |||
| pub fn validate_credentials(user: &GlobalUser) -> Result<(), failure::Error> { | |||
| let client = http::cf_v4_api_client(user, HttpApiClientConfig::default())?; | |||
| let client = http::auth_client(user)?; | |||
There was a problem hiding this comment.
the distinction for this client really is that it is optimized as a client for the cloudflare API, not that it includes auth info, so i'd be inclined to leave this name as it was.
src/http/cf.rs
Outdated
| ) | ||
| } | ||
|
|
||
| pub fn kv_auth_client(user: &GlobalUser) -> Result<HttpApiClient, failure::Error> { |
There was a problem hiding this comment.
yeah prolly. or we handle config less centrally in another iteration of this refactor
EverlastingBugstopper
force-pushed
the
avery/uniform-user-agent
branch
from
f21dfcf
to
c0e3f73
Compare
EverlastingBugstopper
added
changelog - maintenance
and removed
changelog - feature
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731