This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
😈 1.8.1 #1116
Merged
😈 1.8.1 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exvuma
force-pushed
the
1.8.1/changelog
branch
2 times, most recently
from
149c4b6
to
1e2f225
Compare
EverlastingBugstopper
suggested changes
Mar 3, 2020
CHANGELOG.md
Outdated
Comment on lines
7
to
9
| - **Corrects watch from not updating properly for `wrangler dev` - [EverlastingBugstopper], [issue/1082][pull/1117]** | ||
|
|
||
| Updates to a Worker script in a text editor would not trigger the terminal running `wrangler dev` to update automatically. This fix makes sure the multiple threads running on wrangler get an updated lock whenever a reload is detected instead of depending on routine lock checks. |
There was a problem hiding this comment.
Suggested change
| - **Corrects watch from not updating properly for `wrangler dev` - [EverlastingBugstopper], [issue/1082][pull/1117]** | |
| Updates to a Worker script in a text editor would not trigger the terminal running `wrangler dev` to update automatically. This fix makes sure the multiple threads running on wrangler get an updated lock whenever a reload is detected instead of depending on routine lock checks. | |
| - **Fix live reload for `wrangler dev` - [EverlastingBugstopper], [issue/1082][pull/1117]** | |
| `wrangler dev` re-builds and re-uploads your script to the Cloudflare API when it detects a file change. The Cloudflare API returns a new token which allows `wrangler dev` to route subsequent requests to the new script. Previously, `wrangler dev` would re-build, re-upload, and receive the new token, but it wouldn't use it for a couple of minutes due to some faulty threading logic. (darn mutexes!) After this change, `wrangler dev` will block incoming requests when it is switching the token, thus fixing the issue. |
There was a problem hiding this comment.
Body should be updated as well here
Co-Authored-By: Avery Harnish <[email protected]>
gabbifish
approved these changes
Mar 3, 2020
Co-Authored-By: Avery Harnish <[email protected]>
EverlastingBugstopper
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.