This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
reinstate kv buckets #1125
Merged
reinstate kv buckets #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
force-pushed
the
alewis/re-instate-kv-buckets
branch
2 times, most recently
from
0d1987e
to
4d51b54
Compare
ashleymichal
force-pushed
the
alewis/re-instate-kv-buckets
branch
2 times, most recently
from
34cf19b
to
aaa14d9
Compare
ashleymichal
commented
Mar 6, 2020
ashleymichal
force-pushed
the
alewis/re-instate-kv-buckets
branch
from
aaa14d9
to
d5a4ed3
Compare
ashleymichal
force-pushed
the
alewis/delay-kv-bulk-delete
branch
from
35c01d3
to
8bffa1c
Compare
ashleymichal
force-pushed
the
alewis/re-instate-kv-buckets
branch
from
d5a4ed3
to
0a37c3c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
in #1115 i removed this feature to clean up the logic around site deploys, however regression testing revealed that there's a slight possibility that some users might be using this functionality in production and we don't want to introduce that kind of breaking change. This PR re-instates the feature, and smooths it out a little, but also introduces a deprecation warning, as this feature is not well thought out and was not intended to be released in the first place. we will monitor for responses to the warning to decide next steps.
Also happened
to get the "feature" header in to see who uses this crazy side effect, i refactored
upload::scriptto take a client as an argument. i actually think this will be beneficial for future unit testing efforts.Still TODO
message::billboardfor deprecation warning