This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
[dev] connect to edge websocket #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 19, 2020
EverlastingBugstopper
force-pushed
the
avery/edge-dev-socket
branch
from
8b98fd2
to
cd14794
Compare
…s-token-as-get-param Pass token as GET parameter instead of header for preview requests
EverlastingBugstopper
changed the title
EverlastingBugstopper
changed the base branch from
avery/edge-dev-server
to
avery/edge-dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should Just Work once API change goes through to move websocket auth to url from header