This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually - it looks like we already have a convenience function for this that should make it easier + uniform with the way we display errors.
It is
crate::http::format_error
, and it takes anApiFailure
, and an optional function to handle individual error codes.So you could write something real quick to include the suggestions for codes
10026
and10014
and pass it to that function. You can see an example of this incrate::src::commands::route::delete
, at the end there is amatch result
and it callshttp::format_error
This should allow us to display the error without making it look like an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(if i had thought of this before i would have pointed you in that direction!)