This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
add --preview to kv:key, kv:bulk + kv:namespace #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's probably colliding with the other preview arg. |
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
728dede
to
76033a5
Compare
EverlastingBugstopper
changed the title
|
i figured it out |
|
@ashleymichal ur refactor made this so easy thank u so much |
|
are you adding for kv:namespace in a separate pr? |
|
wasn't planning on doing for |
i think it would only change the messaging around what to put in your toml. |
EverlastingBugstopper
changed the title
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
f7ca857
to
6327057
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
6327057
to
69f1fe7
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
2 times, most recently
from
8a9f90e
to
803db3e
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
803db3e
to
4b75382
Compare
ashleymichal
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets do it up