This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
add --preview to kv:key, kv:bulk + kv:namespace #1360
Merged
EverlastingBugstopper
merged 6 commits into
avery/sneaky-snakey-preview
from
avery/kv-preview
Jun 10, 2020
Merged
add --preview to kv:key, kv:bulk + kv:namespace #1360
EverlastingBugstopper
merged 6 commits into
avery/sneaky-snakey-preview
from
avery/kv-preview
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's probably colliding with the other preview arg. |
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
June 3, 2020 22:19
728dede
to
76033a5
Compare
EverlastingBugstopper
changed the title
[wip] add --preview to kv:key and kv:bulk
add --preview to kv:key and kv:bulk
Jun 3, 2020
i figured it out |
@ashleymichal ur refactor made this so easy thank u so much |
are you adding for kv:namespace in a separate pr? |
wasn't planning on doing for |
i think it would only change the messaging around what to put in your toml. |
EverlastingBugstopper
changed the title
add --preview to kv:key and kv:bulk
add --preview to kv:key, kv:bulk + kv:namespace
Jun 8, 2020
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
June 10, 2020 15:09
f7ca857
to
6327057
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
June 10, 2020 15:44
6327057
to
69f1fe7
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
2 times, most recently
from
June 10, 2020 17:11
8a9f90e
to
803db3e
Compare
EverlastingBugstopper
force-pushed
the
avery/kv-preview
branch
from
June 10, 2020 17:13
803db3e
to
4b75382
Compare
ashleymichal
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets do it up