Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

increases default HTTP timeout to 1 min #1392

Merged
merged 1 commit into from
Jun 16, 2020
Merged

increases default HTTP timeout to 1 min #1392

merged 1 commit into from
Jun 16, 2020

Conversation

EverlastingBugstopper
Copy link
Contributor

should fix #1386

@EverlastingBugstopper EverlastingBugstopper added this to the 1.10.1 milestone Jun 16, 2020
@EverlastingBugstopper EverlastingBugstopper requested a review from a team as a code owner June 16, 2020 16:44
ashleymichal
ashleymichal suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@ashleymichal ashleymichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably care about the featured clients as well yes? perhaps we should have a constant "default timeout"

ispivey
ispivey reviewed Jun 16, 2020
View reviewed changes
src/http/mod.rs Outdated Show resolved Hide resolved
ashleymichal
ashleymichal reviewed Jun 16, 2020
View reviewed changes
src/http/mod.rs Outdated Show resolved Hide resolved
@ispivey ispivey mentioned this pull request Jun 16, 2020
Merged
@EverlastingBugstopper EverlastingBugstopper merged commit 8da2bde into master Jun 16, 2020
@EverlastingBugstopper EverlastingBugstopper deleted the avery/increase-upload-timeout branch August 3, 2020 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ispivey ispivey ispivey left review comments

@ashleymichal ashleymichal ashleymichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

Error sending request for url (...): operation timed out
3 participants
@EverlastingBugstopper @ispivey @ashleymichal