move batching into bulk module code #1400

ashleymichal · 2020-06-19T19:00:01Z

src/kv/bulk.rs

src/main.rs

ashleymichal · 2020-06-19T19:18:39Z

src/preview/upload.rs

@@ -70,15 +69,15 @@ pub fn upload(
                        message::info("Uploading updated files...");
                    }

-                    upload_files(target, user, &site_namespace.id, to_upload)?;
+                    bulk::put(target, user, &site_namespace.id, to_upload, &None)?;


should we use a progress bar here? didn't before but can add.

That would make sense to me, right now it just says nothing and it might look like it's hanging

src/sites/upload.rs

jspspike

Everything looks good to me and after testing I got good behavior.

 Built successfully, built project size is 12 KiB.
 Using namespace for Workers Site "__site-workers_sites_assets"
 Success
 Uploading site files
█████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 11001/11001
Done Uploading
 Successfully published your script to https://site.ftc.workers.dev
 Deleting stale files...
█████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 11001/11001
Done deleting

EverlastingBugstopper

tested this, it works and it looks like good programming

move batching into bulk module code

48bf2a5

ashleymichal added status - needs review regression Something is broken, but works in previous releases sites labels Jun 19, 2020

ashleymichal added this to the 1.10.2 milestone Jun 19, 2020

ashleymichal requested a review from a team as a code owner June 19, 2020 19:00

ashleymichal self-assigned this Jun 19, 2020