Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Wrangler Login #1471

Merged
merged 11 commits into from
Aug 3, 2020
Merged

Wrangler Login #1471

merged 11 commits into from
Aug 3, 2020

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Jul 30, 2020 •
edited
Loading

This is set up in staging but is ready for review.

@jspspike jspspike force-pushed the josh/login branch 5 times, most recently from 8086f4e to e3c28ea Compare July 30, 2020 17:34
@jspspike jspspike closed this Jul 30, 2020
@jspspike jspspike reopened this Jul 30, 2020
@jspspike jspspike marked this pull request as ready for review July 31, 2020 18:58
@jspspike jspspike requested a review from a team as a code owner July 31, 2020 18:58
@jspspike jspspike requested a review from a team July 31, 2020 19:28
@jspspike jspspike mentioned this pull request Jul 31, 2020
Merged
EverlastingBugstopper
EverlastingBugstopper suggested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things here and there but this is looking really really good

src/login/mod.rs Outdated Show resolved Hide resolved
src/login/mod.rs Outdated Show resolved Hide resolved
src/login/mod.rs Outdated Show resolved Hide resolved
src/login/mod.rs Outdated Show resolved Hide resolved
src/login/mod.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
EverlastingBugstopper
EverlastingBugstopper approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jspspike
Copy link
Contributor Author

jspspike commented Aug 3, 2020

Won't merge this until service changes go into prod

@EverlastingBugstopper
Copy link
Contributor

will want to change the API its using to prod as well once that happens (unless you already did and i missed it)

@jspspike
Copy link
Contributor Author

jspspike commented Aug 3, 2020

will want to change the API its using to prod as well once that happens (unless you already did and i missed it)

I haven't, will do

@jspspike jspspike merged commit e048c15 into master Aug 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the josh/login branch August 3, 2020 19:38
@EverlastingBugstopper EverlastingBugstopper added this to the 1.11.0 milestone Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jspspike @EverlastingBugstopper