Add output option for wrangler publish

[nataliescottdavidson]

wrangler build | publish --output json

Wrangler supports structured output for core commands build and publish. JSON string goes to stdout, stderr displays user output.

js

nat@cf:~/examplejs$wrangler build
💁  JavaScript project found. Skipping unnecessary build!
nat@cf:~/examplejs$wrangler build --output json
{"success":true,"name":"examplejs"}
nat@davidson:~/examplejs$ ../wrangler/target/debug/wrangler publish --output json

^ No output. Confused why that is happening as the logic to create structured output in the publish path should be the same regardless of project type.
Webpack build and publish

nat@davidson:~/demo-site$ ../wrangler/target/debug/wrangler build --output json
{"success":true,"name":"demo-site"}
nat@davidson:~/demo-site$ ../wrangler/target/debug/wrangler publish --output json
{"success":true,"name":"demo-site","urls":["https://demo-site.nats.workers.dev"]}

I'm unfamiliar with assert_cmd and will ramp up on that to make some solid tests.

[jspspike]

If the main difference being messages go to stderr instead of stdout and the json output I think maybe using lazy_static in terminal::message to have a static variable that would change all message functions to go to stderr instead of stdout would be better than having to pass a mutable reference into every function especially if we plan on adding this to other commands since this
reference would basically have to passed everywhere. Thoughts? @EverlastingBugstopper @ashleymichal

Also looks like the lint CI failed, you can fix that by running cargo fmt and cargo clippy. Cool that you're starting work on Wrangler :)

[EverlastingBugstopper]

Agreed, this should all be handled with the message framework, and if there are things we print that don't use that framework they should be migrated

[nataliescottdavidson]

If the main difference being messages go to stderr instead of stdout and the json output I think maybe using lazy_static in terminal::message to have a static variable that would change all message functions to go to stderr instead of stdout would be better than having to pass a mutable reference into every function especially if we plan on adding this to other commands since this
reference would basically have to passed everywhere. Thoughts? @EverlastingBugstopper @ashleymichal

Also looks like the lint CI failed, you can fix that by running cargo fmt and cargo clippy. Cool that you're starting work on Wrangler :)

Thanks for the feedback. It seems like I'll need to set a global variable output_type. That's usually a no-no, but I agree it's nicer than passing around a reference to every logging path.

[jspspike]

It seems like I'll need to set a global variable

It doesn't really need to be global, just a local static variable in terminal::message and then in the message function check the variable and print out to stdout or stderr.

*Sent this right before your updates I'll take a look

[jspspike]

Just a few small things but other than that looks good to me! I'm assuming you'll be adding the url part after this.

[EverlastingBugstopper]

few things here and there but this is looking good 😄

[EverlastingBugstopper]

are these backwards? i think json should go to stdout and human readable should be stderr, no?

[nataliescottdavidson]

json should go to stdout and human readable should be stderr, no?
Yes- IFF json output flag is given. I made the assumption messages are for human readable output. It made sense to me to make a json type here. I'm a rust novice so let me know if there is a better way.
wrangler build | publish --output json

Wrangler supports structured output for core commands build and publish. JSON string goes to stdout, stderr displays user output.

js

nat@cf:~/examplejs$wrangler build
💁  JavaScript project found. Skipping unnecessary build!
nat@cf:~/examplejs$wrangler build --output json
{"success":true,"name":"examplejs"}
nat@davidson:~/examplejs$ ../wrangler/target/debug/wrangler publish --output json `returns no output, need to fix.

Webpack build and publish

nat@davidson:~/demo-site$ ../wrangler/target/debug/wrangler build --output json
{"success":true,"name":"demo-site"}
nat@davidson:~/demo-site$ ../wrangler/target/debug/wrangler publish --output json
{"success":true,"name":"demo-site","urls":["https://demo-site.nats.workers.dev"]}

Next steps: extend to other worker types

[nataliescottdavidson]

Spoke with @ashleymichal about this. Implementation plan is as follows:

1. Refactor message module to follow terminal::message::{StdOut | StdIn}.{info | warn | success}(msg) instead of current state terminal::message.{info, warn. success, etc}.(msg)
2. Change messaging within the wrangler publish path to use stdout only for result of program, everything else goes to stderr
3. Implement this functionality (logic in this PR).
   Let me know if I grossly misinterpreted something...
   Oh and next time I'll make a branch instead of fork so it's easier to pull in my changes😅

[nataliescottdavidson]

closing for #1538