Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Upload .well-known files #1566

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

nataliescottdavidson
Copy link
Contributor

Hack to allow uploading .well-known files as requested by customers using wrangler for static site hosting- some frameworks use these dotfiles

closes #980

Copy link
Contributor

@ashleymichal ashleymichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew. do you think you could write an RFC for replacing walkdir?

@nataliescottdavidson
Copy link
Contributor Author

whew. do you think you could write an RFC for replacing walkdir?

Yep, will do.

@nataliescottdavidson
Copy link
Contributor Author

Right now we use walkdir to traverse the filesystem with an iterator, and for the include/exclude glob logic. Ideally the include/exclude logic would have regex.
To replace walkdir, we would need to write our own directory iterator and include/exclude logic. I think that forking walkdir/include and modifying include to use regex makes the most sense.
For now, I think this hack is worth it to unblock users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always upload .well-known dotfiles
2 participants