This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add support for Cron Triggers #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObsidianMinor
commented
Oct 10, 2020
| } | ||
| } | ||
| #[derive(Debug, PartialEq, Clone)] | ||
| pub enum DeployTarget { |
There was a problem hiding this comment.
@ashleymichal So it turns out removing all type information by using a boxed trait object makes testing and checks in wrangler dev really hard so I decided to just use an enum instead to simplify a lot of stuff...
ObsidianMinor
force-pushed
the
feat/cron-triggers
branch
2 times, most recently
from
4ecdc92
to
bcd04d3
Compare
|
can you please address the clippy issue? |
* This also refactors deployments to accept multiple deploy targets so you aren't limited to zoned, zoneless, or scheduled for one script. * It also removes the constraint that only route or routes can be used. If both are specified, routes will have route inserted at the beginning
ObsidianMinor
force-pushed
the
feat/cron-triggers
branch
from
a1c2f3e
to
b1a9fa5
Compare
ashleymichal
suggested changes
Oct 22, 2020
|
I checked this out, added |
|
@nataliescottdavidson It needs to be added under a name = "wrangled-scheduled"
type = "javascript"
account_id = "blah"
[triggers]
crons = ["* * * * *"] |
ObsidianMinor
force-pushed
the
feat/cron-triggers
branch
from
3ecfa79
to
69e2e2e
Compare
| name: target.name.clone(), | ||
| urls, | ||
| schedules, | ||
| }); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors deployments to accept multiple deploy targets so you
aren't limited to zoned, zoneless, or scheduled for one script.
It also removes the constraint that only route or routes can be used.
If both are specified, routes will have route inserted at the beginning
This fixes #1574