-
Notifications
You must be signed in to change notification settings - Fork 337
Add support for Cron Triggers #1592
Add support for Cron Triggers #1592
Conversation
} | ||
} | ||
#[derive(Debug, PartialEq, Clone)] | ||
pub enum DeployTarget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashleymichal So it turns out removing all type information by using a boxed trait object makes testing and checks in wrangler dev
really hard so I decided to just use an enum instead to simplify a lot of stuff...
4ecdc92
to
bcd04d3
Compare
can you please address the clippy issue? |
* This also refactors deployments to accept multiple deploy targets so you aren't limited to zoned, zoneless, or scheduled for one script. * It also removes the constraint that only route or routes can be used. If both are specified, routes will have route inserted at the beginning
a1c2f3e
to
b1a9fa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future PRs, it would be helpful to separate the refactors and feature work into different commits.
let's tidy up the output and tests. also have a look to see if there's changes needed to the readme.
I checked this out, added |
@nataliescottdavidson It needs to be added under a name = "wrangled-scheduled"
type = "javascript"
account_id = "blah"
[triggers]
crons = ["* * * * *"] |
3ecfa79
to
69e2e2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks mucho!
name: target.name.clone(), | ||
urls, | ||
schedules, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent
This also refactors deployments to accept multiple deploy targets so you
aren't limited to zoned, zoneless, or scheduled for one script.
It also removes the constraint that only route or routes can be used.
If both are specified, routes will have route inserted at the beginning
This fixes #1574