This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
remove webpack specific change #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
force-pushed
the
sven/remove-webpack-change
branch
from
f45bba2
to
b239c43
Compare
xortive
reviewed
Jan 14, 2021
xtuc
force-pushed
the
sven/remove-webpack-change
branch
from
b239c43
to
472faa1
Compare
xortive
approved these changes
Jan 15, 2021
We used to hook directly into webpack internals to rewrite the runtime that loads Wasm to make it point to the Worker binding instead of a network fetch. This change removes the webpack specific change and injects a generic runtime to load Wasm from the binding.
xtuc
force-pushed
the
sven/remove-webpack-change
branch
from
472faa1
to
1d033db
Compare
|
changed to emit the JS runtime only if wasm is actually used. Avoids breaking source maps for others |
This was referenced Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to hook directly into webpack internals to rewrite the runtime
that loads Wasm to make it point to the Worker binding instead of a
network fetch.
This change removes the webpack specific change and injects a generic
runtime to load Wasm from the binding.
Demo of the webpack's generated code: https://gist.github.com/xtuc/1a96d6793a3729016a518416ecf5b585#file-demo-js-L2-L9. I used https://github.com/xtuc/rust-webpack-worker-demo to test.