This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Display account ID's when possible #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2021 15:53
Also deals with some of the pub stuff
xortive
reviewed
Mar 1, 2021
Comment on lines
+22
to
+23
| display_account_id_maybe(); | ||
| failure::bail!("field `account_id` is required to deploy to workers.dev") |
There was a problem hiding this comment.
Suggested change
| display_account_id_maybe(); | |
| failure::bail!("field `account_id` is required to deploy to workers.dev") | |
| failure::bail!("field `account_id` is required to deploy to workers.dev") | |
| display_account_id_maybe(); |
I think this will give nicer output maybe?
There was a problem hiding this comment.
the issue is that bailing just instantly returns, but i agree. i'll see if there's another way
xortive
approved these changes
Mar 1, 2021
|
So happy to finally see this happen :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, users had to log in to their dash to view their account IDs. This PR extracts some of the code used in
whoamito log their account IDs to the terminal, instead. If for some reason that doesn't work, it'll fall back to telling them where to go to find them on the dash.