This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
[WIP] Update tokio ecosystem #1880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
reviewed
Apr 27, 2021
nilslice
reviewed
Apr 27, 2021
There was a problem hiding this comment.
publish and dev are working, buttail hangs endlessly on This may take a few seconds.... I can investigate a bit as I was just working on tail. Thanks for this @caass , getting us out of dependency hell!
For anyone else reading (i talked with @nataliescottdavidson offline), I'm pretty sure the issue has to do with message passing between different tasks, that'll be the next commit, i think. |
Merged
|
Closing in favor of #1886 |
kflict
referenced
this pull request
in CollectiveSynthesis2021/ORGIN2
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade to tokio 1.0 to get unblocked on using the latest version of
cloudflare-rs.This PR updates tokio and related libs to 1.0 so we can continue using
cloudflare-rs. This also unblocks tail v2.related: #1881