Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

wrangler tail using WebSockets #2005

Merged
merged 13 commits into from
Jul 30, 2021
Merged

wrangler tail using WebSockets #2005

merged 13 commits into from
Jul 30, 2021

Conversation

nataliescottdavidson
Copy link
Contributor

No description provided.

@nataliescottdavidson nataliescottdavidson requested a review from a team as a code owner July 20, 2021 18:56
Electroid
Electroid reviewed Jul 20, 2021
View reviewed changes
src/commands/tail.rs Outdated Show resolved Hide resolved
src/commands/tail.rs Outdated Show resolved Hide resolved
Electroid
Electroid reviewed Jul 23, 2021
View reviewed changes
src/cli/mod.rs Show resolved Hide resolved
src/commands/tail.rs Outdated Show resolved Hide resolved
aaronlisman
aaronlisman reviewed Jul 23, 2021
View reviewed changes
Copy link

@aaronlisman aaronlisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I didn't mean to start a review.

src/commands/tail.rs Outdated Show resolved Hide resolved
This was linked to issues Jul 23, 2021
wrangler tail failing silently — consider adding -p 0 as default? #1965
Closed
wrangler tail can fail if cloudflared is setup using a shared config path #1844
Closed
@Electroid Electroid changed the title Tail v2 client wrangler tail using WebSockets Jul 23, 2021
ObsidianMinor
ObsidianMinor reviewed Jul 23, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Electroid Electroid requested review from nilslice and caass July 28, 2021 15:55
@Electroid Electroid linked an issue Jul 28, 2021 that may be closed by this pull request
[tail] fix error message on tail session expiration #1265
Closed
@nataliescottdavidson
Copy link
Contributor Author

@Electroid filters look good.
image

@Electroid Electroid self-requested a review July 29, 2021 16:54
@Electroid Electroid merged commit de00b8b into master Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the tails-v2 branch July 30, 2021 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ObsidianMinor ObsidianMinor ObsidianMinor left review comments

@aaronlisman aaronlisman aaronlisman left review comments

@Electroid Electroid Electroid approved these changes

@nilslice nilslice Awaiting requested review from nilslice

@caass caass Awaiting requested review from caass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nataliescottdavidson @Electroid @ObsidianMinor @aaronlisman