-
Notifications
You must be signed in to change notification settings - Fork 337
Allow running wrangler dev
without an account_id
#2030
Conversation
6f84085
to
4488b0c
Compare
So, I'm hitting more test failures ... the current ones are
I think this is because they expect |
c6c4a00
to
35ec3ac
Compare
@Electroid this is ready for review. |
@caass mentioned wanting to test this with Durable Objects and KV namespaces, but I'm not sure how to do that ... happy to do so if someone can write up instructions. I tried
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and seems to be working as intended, other than that one commented out tests it looks good to me
Previously, running it with no account_id and no config in ~/.wrangler would give an error: ``` Error: config path does not exist /home/jnelson/.wrangler/config/default.toml. Try running `wrangler login` or `wrangler config` ``` This is not technically a regression from loading account_id lazily, because in wrangler 1.17 it would just error earlier that account_id was required: ``` 🕵️ You can find your account_id in the right sidebar of your account's Workers page Error: field `account_id` is required to deploy to workers.dev ``` However, it seems odd that you'd have to have an account to run an unauthenticated preview. This changes wrangler to only require an account_id or config file if you're actually deploying your site. This also changes the tests not to expect that wrangler requires an account_id just to load the available deployments.
35ec3ac
to
45aaf18
Compare
Previously, running it with no account_id and no config in ~/.wrangler would give an error:
This is not technically a regression from loading account_id lazily, because in wrangler 1.17 it would just error earlier that account_id was required:
However, it seems odd that you'd have to have an account to run an unauthenticated preview.
This changes wrangler to only require an account_id or config file if you're actually deploying your site.
Fixes #1525