Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

2032: Upgrade tar dependency #2033

Merged
merged 2 commits into from
Aug 19, 2021
Merged

2032: Upgrade tar dependency #2033

merged 2 commits into from
Aug 19, 2021

Conversation

dhaynespls
Copy link
Contributor

Fixes #2032

@dhaynespls dhaynespls requested a review from a team as a code owner August 19, 2021 16:36
@dhaynespls dhaynespls removed the request for review from kristianfreeman August 19, 2021 16:38
@jyn514
Copy link
Contributor

jyn514 commented Aug 19, 2021

@dhaynespls why did you remove the npmshrinkwrap file?

@dhaynespls
Copy link
Contributor Author

@jyn514 Shouldn't be removed -- just a big diff
image

@dhaynespls
Copy link
Contributor Author

I specifically ran npm audit fix w/ npm version 6.14.5

jyn514
jyn514 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit that's not worth blocking on, let's get this merged :)

npm/npm-shrinkwrap.json
"version": "1.18.0",
"lockfileVersion": 2,
"version": "1.19.0",
"lockfileVersion": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found why it changed so much - do you have an old version of npm maybe?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix me

@jyn514 jyn514 mentioned this pull request Aug 19, 2021
Merged
@jyn514 jyn514 merged commit 5675efa into cloudflare:master Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironheart36925 ironheart36925 ironheart36925 left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade tar dependency to a non vulnerable version
3 participants
@dhaynespls @jyn514 @ironheart36925