This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix wrangler dev session expiration #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electroid
changed the title
Electroid
commented
Sep 15, 2021
src/commands/dev/edge/watch.rs
Outdated
Comment on lines
55
to
57
| StdOut::warn(&format!( | ||
| "{}\nPlease terminate `wrangler dev` using Ctrl+C.", | ||
| &err.0 |
There was a problem hiding this comment.
Hmm, can we not restart it for the user? That's essentially what it use to do.
There was a problem hiding this comment.
Yes, I believe we can do that. Fixing
jyn514
reviewed
Sep 15, 2021
| checksum = "66c99696f6c9dd7f35d486b9d04d7e6e202aa3e8c40d553f2fdf5e7e0c6a71ef" | ||
| dependencies = [ | ||
| "libc", | ||
| ] |
There was a problem hiding this comment.
This seems like a good change, but I'm not sure what it has to do with this PR?
jyn514
suggested changes
Sep 15, 2021
|
Please add a description to this PR. |
threepointone
approved these changes
Sep 15, 2021
jyn514
approved these changes
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #2068. API errors related to syntax or preview token return the same
bad_requeststatus code, and the changes should address these two particular cases.In the future, it would be great to update the legacy client code for better API error handling.