Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

[sites] Don't delete unused assets #2096

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Commits on Oct 8, 2021

  1. [sites] Don't delete unused assets

    We have a consistency issue when after uploading a new site, it takes a while for the worker to propagate, so incoming requests will try to fetch older assets, and 404. This isn't an issue just with us, it's a common scenario. besides, there's no real reason to delete older assets, we don't have limits on how many keys we use (https://developers.cloudflare.com/workers/platform/limits#kv-limits). Maybe someone could write a script that does a cleanup, but there's no reson to delete previous deployments assets immediately. (This matches Pages behaviour too).
    
    This PR removes the functionality where we delete unused assets on fresh uploads.
    threepointone committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    2e13eee View commit details
    Browse the repository at this point in the history
  2. Update npm-shrinkwrap.json

    via `npm audit fix`
    threepointone committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    0b14142 View commit details
    Browse the repository at this point in the history
  3. lint fix

    threepointone committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a66bc64 View commit details
    Browse the repository at this point in the history