Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Update hash comment to changed XxHash64 usage #2124

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Update hash comment to changed XxHash64 usage #2124

merged 2 commits into from
Nov 4, 2021

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented Nov 4, 2021

As introduced in #1221

@dcousens dcousens requested a review from a team as a code owner November 4, 2021 07:23
dcousens
dcousens commented Nov 4, 2021
View reviewed changes
src/sites/mod.rs Outdated Show resolved Hide resolved
@threepointone
Copy link
Contributor

This would break existing sites and churn installations. I don't think we should do this .

threepointone
threepointone suggested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned.

@threepointone
Copy link
Contributor

Oh wait, this doesn't change the implementation

threepointone
threepointone approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@threepointone threepointone merged commit 05be611 into cloudflare:master Nov 4, 2021
@dcousens dcousens deleted the patch-1 branch November 4, 2021 10:03
@nataliescottdavidson nataliescottdavidson mentioned this pull request Nov 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@threepointone threepointone threepointone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcousens @threepointone