Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Remove unneeded heartbeat logic with sketchy time addition #2129

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Remove unneeded heartbeat logic with sketchy time addition #2129

merged 2 commits into from
Nov 9, 2021

Conversation

nataliescottdavidson
Copy link
Contributor

No description provided.

@nataliescottdavidson nataliescottdavidson requested a review from a team as a code owner November 9, 2021 20:47
threepointone
threepointone approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving pending the lint fix, but I also have a question - is the heartbeat not necessary anymore? What is the consequence of removing this code?

@nataliescottdavidson
Copy link
Contributor Author

Tentatively approving pending the lint fix, but I also have a question - is the heartbeat not necessary anymore? What is the consequence of removing this code?

The expiry duration is static for v2, so it is no longer needed.

@nataliescottdavidson nataliescottdavidson merged commit 5e1d241 into master Nov 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-heartbeat branch November 9, 2021 22:09
@nataliescottdavidson nataliescottdavidson mentioned this pull request Nov 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@threepointone threepointone threepointone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataliescottdavidson @threepointone