This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
r2 bindings and subcommands #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorlee
force-pushed
the
taylorlee/r2-bindings-and-subcommands
branch
from
9b4d7be
to
31ccbc6
Compare
|
Excellent |
note: the api-backends for these features are implemented, but generally available in production yet. commands: add r2 subcommands to create/delete/list buckets I opted for sub-commands like wrangler r2 bucket create, rather than how kv does wrangler kv:namespace create. bindings: add support for binding a bucket to a worker this implementation is essentially copy-pasted from the kv binding code, and functions very similary.
taylorlee
force-pushed
the
taylorlee/r2-bindings-and-subcommands
branch
from
d99e3f7
to
803d552
Compare
|
jspspike
approved these changes
Jan 21, 2022
delete-merged-branch
bot
deleted the
taylorlee/r2-bindings-and-subcommands
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr implements two pieces of r2 functionality for the wrangler client:
commands: add r2 sub-commands to create/delete/list buckets
I opted for sub-commands like
wrangler r2 bucket create, rather than how kv doeswrangler kv:namespace create.bindings: add support for binding a bucket to a worker
this implementation is essentially copy-pasted from the kv binding code, and functions very similarly.
preview isn't implemented yet, even though preview_bucket_name can be set currently.