This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Update path-slash to v0.2.1 #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhysd thanks so much for your PR! I'd love to get this merged -- would you mind resolving the merge conflicts? Once that's done I'd be happy to update our deps :) |
rhysd
force-pushed
the
path-slash-0.2.1
branch
from
879490b
to
c77b39f
Compare
|
@caass Thank you for taking a look. I rebased this branch onto the latest master. |
caass
approved these changes
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm author of path-slash crate.
I noticed this big project uses older version of path-slash so I created this PR to update the version. In path-slash v0.2,
to_slash_lossyreturnsCowand allocates memory only when it is necessary so this change may be able to save some heap allocations.