This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
feat: adds more descriptive subdomain errors #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
approved these changes
Jun 20, 2019
src/commands/subdomain.rs
Outdated
| ); | ||
| if sd == name { | ||
| println!( | ||
| "{} Your subdomain {}.workers.dev has already been registered!", |
There was a problem hiding this comment.
I would read this as "Your subdomain has already been registered (by someone else)" – is that the intent here? If not, should it be something like "You've already registered the subdomain xyz.workers.dev"?
There was a problem hiding this comment.
Yeah so this case is specifically for when the user is trying to register the subdomain that they themselves have already registered. The latter makes sense to me
Warns users when attempting to add a subdomain w/o account_id in wrangler.toml Doesn't show failure when attempting to register the subdomain that is already associated with their account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warns users when attempting to add a subdomain w/o account_id in
wrangler.toml
Doesn't show failure when attempting to register the subdomain that
is already associated with their account
Fixes #207