Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Add message module for terminal output #263

Merged
merged 4 commits into from
Jun 25, 2019

Conversation

ashleymichal
Copy link
Contributor

@ashleymichal ashleymichal commented Jun 21, 2019

fixes #219

  • include semantic commands for success, info, warn, etc.
  • alphabetize emoji 🤓
  • replace some remaining inline emoji

@ashleygwilliams
Copy link
Contributor

looks like you have an import error and some dead code warnings! lemme know if you need help with those :)

@ashleygwilliams
Copy link
Contributor

adding @granjef3 as a reviewer as we'll tap him to finish out this migration :)

Copy link
Contributor

@xortive xortive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup a lot. The unused emojis/functions clippy sees are definitely useful, and I think it would be better to find a place for them to be used then to delete them.

src/terminal/message.rs Outdated Show resolved Hide resolved
src/commands/build/wranglerjs/bundle.rs Outdated Show resolved Hide resolved
src/terminal/emoji.rs Outdated Show resolved Hide resolved
src/terminal/emoji.rs Show resolved Hide resolved
src/terminal/message.rs Show resolved Hide resolved
src/terminal/message.rs Show resolved Hide resolved
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! there's a little more work left to audit the whole codebase and make sure everything is consistent- i'd recommend merging this ASAP to establish the pattern, maybe @granjef3 can take on the full audit post merge?

Copy link
Contributor

@xortive xortive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. quick grep for stray "println!" only shows some in the installer.

@ashleygwilliams ashleygwilliams merged commit 5bdbbaa into master Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the alewis/unified-terminal-output branch June 25, 2019 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize terminal messaging output function
3 participants