This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
xtuc
reviewed
Jun 24, 2019
This might be too much of a maintenance burden, but I think it would be nice if we had a small section on "How to work on wrangler" with like a very high-level map of the codebase, and how to build/install a local copy of wrangler. |
@granjef3 i'm super down for that! if you open an issue i think that'd be great |
ashleygwilliams
changed the title
[WIP] feat(docs): add CONTRIBUTING.md
feat(docs): add CONTRIBUTING.md
Jul 3, 2019
ashleymichal
approved these changes
Jul 3, 2019
CONTRIBUTING.md
Outdated
received all required reviews. | ||
- All PRs should be labelled with a changelog label: BREAKING, Feature, Bug, Maintenance, Docs | ||
|
||
### Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this section TODO or should we remove the heading?
ashleygwilliams
added
regression
Something is broken, but works in previous releases
status - changes requested
labels
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.