Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Update README to include config, env var changes #379

Merged
merged 10 commits into from
Aug 9, 2019

Conversation

ashleymichal
Copy link
Contributor

For 1.1.0 we updated wrangler config to be an interactive prompt for security reasons, but we also introduced environment variables for the values configured with that command for the sake of users integrating Wrangler into their CI pipelines. This PR updates the README to reflect those changes.

Fixes #378 , #377

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nit in two areas. Otherwise LGTM :)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@kristianfreeman
Copy link
Contributor

@gabbifish @ashleymichal I ran the demo GIF through gifsicle and shrinked it from over 1mb to ~200kb! Want to update with this?

wrangler-demo-optim

@ashleygwilliams
Copy link
Contributor

vaguely blocked on this cloudflare/worker-template#14

@kristianfreeman
Copy link
Contributor

cloudflare/worker-template#14 is merged

@ashleymichal ashleymichal merged commit f9c7e4d into master Aug 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the alewis/config-readme branch August 9, 2019 18:48
Rhilip added a commit to Rhilip/pt-gen-cfworker that referenced this pull request Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README with changes to config command, env vars
4 participants